Merged
Conversation
tomkis
changed the title
dosubot
bot
added
the
size:XL
tomkis
force-pushed
the
chore/1472-form-extension-rework
branch
from
758bb3c to
4639312
Compare
Collaborator
Author
|
@dosu what are the affected docs in docs folder? |
|
Hi @tomkis! I'm Dosu and I’m helping the agentstack team. The affected docs in the docs folder are:
All these changes were made in PR #1137. No other docs in the folder were changed by the form extension rework. To reply, just mention @dosu. How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other |
tomkis
force-pushed
the
chore/1472-form-extension-rework
branch
from
3dbff2d to
d0c66c1
Compare
Collaborator
Author
|
@jenna-winkler this is a breaking change for the 0.4.X users, we'll bump up the version to 0.5.0. We should provide migration guide that can be prepared from the diff in documentation in this PR. |
tomkis
commented
Nov 7, 2025
| @@ -778,9 +783,9 @@ async def run_agent( | |||
|
|
|||
| initial_form_render = next( | |||
Collaborator
Author
There was a problem hiding this comment.
We should probably refactor this and use the extension client and parse as service extension cc @jezekra1
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed rework of the form extension, splitting it into a service extension for initial forms and a UI extension for dynamic form requests. This refactoring improves modularity and clarifies the distinction between different form use cases. The changes are consistently applied across the Python SDK, TypeScript SDK, CLI, and UI applications, and the documentation has been updated accordingly. I've identified a couple of issues: a potential KeyError and a typo in the Python SDK, and a state mutation bug in the React UI. Once these are addressed, this will be a solid improvement to the codebase.
apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/services/form.py
Outdated
Show resolved
Hide resolved
apps/agentstack-ui/src/modules/runs/contexts/agent-demands/AgentDemandsProvider.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed refactoring of the form extensions. The original FormExtension is split into FormServiceExtension for initial, agent-demanded forms, and RequestFormExtension for dynamic, UI-requested forms. This separation greatly improves clarity and the developer experience. The changes are consistently applied across the Python SDK, TypeScript SDK, CLI, UI components, and documentation. The new APIs are more intuitive, especially with the improved model-based form parsing. Overall, this is an excellent improvement. I have a couple of minor suggestions to clean up a small piece of potentially confusing code in the UI context providers.
apps/agentstack-ui/src/modules/runs/contexts/agent-demands/agent-demands-context.ts
Show resolved
Hide resolved
apps/agentstack-ui/src/modules/runs/contexts/agent-run/AgentRunProvider.tsx
Show resolved
Hide resolved
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed refactoring of the form extensions, separating initial form services from dynamic UI form requests. The changes are consistent across the Python SDK, TypeScript SDK, CLI, and documentation, leading to a much clearer and more robust API. I've found one high-severity issue in the UI implementation where incorrect metadata could be sent for initial form submissions, and I've provided a fix. Once that's addressed, this will be an excellent improvement.
apps/agentstack-ui/src/modules/runs/contexts/agent-run/AgentRunProvider.tsx
Show resolved
Hide resolved
PetrBulanek
requested changes
Nov 13, 2025
apps/agentstack-sdk-ts/src/client/a2a/extensions/common/form.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/client/a2a/extensions/handle-input-required.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/client/a2a/extensions/services/form.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-ui/src/modules/runs/contexts/agent-run/AgentRunProvider.tsx
Outdated
Show resolved
Hide resolved
apps/agentstack-ui/src/modules/runs/contexts/agent-demands/AgentDemandsProvider.tsx
Show resolved
Hide resolved
PetrBulanek
force-pushed
the
chore/1472-form-extension-rework
branch
from
55474d5 to
2d6faea
Compare
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
PetrBulanek
force-pushed
the
chore/1472-form-extension-rework
branch
from
9093294 to
94c0d5b
Compare
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
PetrBulanek
approved these changes
Nov 19, 2025
kapetr
approved these changes
Nov 19, 2025
edengilbert
pushed a commit
to edengilbert/agentstack
that referenced
this pull request
Nov 21, 2025
Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com>
edengilbert
added a commit
that referenced
this pull request
Nov 21, 2025
…1513) * Add blog post: How to Run a BeeAI Framework Agent as an A2A Server Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * Finalize A2A Server blog post after preview edits Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * Update a2a-server.mdx Updated based on gemini feedback Signed-off-by: Eden Gilbert <117227212+edengilbert@users.noreply.github.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): group trajectories (#1482) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): proactive access_token refresh to avoid refresh race (#1501) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): runtime envs and feature flags cleanup (#1479) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): render mermaid diagrams and latex syntax in markdown (#1488) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(sdk): utilize platform auth in mcp extension (#1508) Signed-off-by: Tomas Pilar <thomas7pilar@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(server): add user info endpoint (#1505) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: remove redundant ToC from connectors guide (#1519) Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): array length checks (#1526) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat: initial implementation for connectors management in UI (#1443) * feat: initial implementation for connectors management in UI Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * feat: connectors prep work Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * feat: proper error handling Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: missing licence headers Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: imports Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: missing schema Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: post rebase adjustments Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: proper schema Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: code review comments Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> --------- Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: update deployment guide (#1525) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): make 'add new agent' button admin only (#1527) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: overhaul (#1540) Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(docs): add guide on connecting CLI to remote servers (#1541) Signed-off-by: Tomas Pilar <thomas7pilar@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(server): refresh unmanaged agent cards (#1528) Signed-off-by: Aleš Kalfas <kalfas.ales@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: minor changes (#1545) Signed-off-by: Matous Havlena <havlenma@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: docs workflow (#1502) * chore: docs workflow Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: better quoting Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: better git habndling Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: improve PR template Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: provide docs Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> --------- Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: bump up uvicorn timeouts to 5s, make configurable (#1548) Signed-off-by: Matous Havlena <havlenma@gmail.com> Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Co-authored-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(server): connectors header forwading (#1553) Signed-off-by: Tomas Pilar <thomas7pilar@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc1 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: add explicit WSL instructions Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix: long operations inside transactions cause db connection exhaustion (#1549) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * ci: add missing mise.lock checksums Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(agentstack-cli): clarify agent statuses (fixes #1535) Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(agentstack-cli): redesign agentstack list output Fixes #1536 Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs(agentstack-cli): add custom help text (#1554) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: improve WSL2 installation instructions Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * Update deployment-guide.mdx (#1573) Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: fixing dead links in the docs (#1557) Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * refactor(web): use single framewok-diagram.svg file themeable with CSS variables (#1539) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * refactor(ui): rework Spinner component with CSS only animation, remove lottie-react (#1538) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(agentstack-cli): properly react to misconfigured WSL2 Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs(agentstack-cli): clarify WSL install steps Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(agentstack-cli): add `agentstack server switch` alias Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): remove links to docs and support (#1570) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore(ui): update "starting the agent" copy (#1571) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): messages being cut off on narrower screens (#1546) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): hide offline agents (#1434) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): render Markdown syntax inside trajectories (#1555) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore(server): add resource discovery root fallback to connectors (#1587) Signed-off-by: Tomas Pilar <thomas7pilar@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): update homepage and sidebar (#1512) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: remove unnecessary __init__.py (#1494) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): replace trajectory group with latest content, add docs (#1523) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): mute error toasts on session expiration (#1589) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix: avoid setting up embeddings on RITS resolves #1578 Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat: update beeai-framework Signed-off-by: Tomas Dvorak <toomas2d@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * Update README.md (#1569) * Update README.md Add Radek's agent as reference Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> * Update README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> * Update README.md * Update README.md * Update README.md Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> --------- Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: cleanup (#1586) * docs: updates Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> * Update docs/docs.json Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> * Update authenticate-cli-to-server.mdx Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> * Update README.md Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> * docs: updates --------- Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(helm): peroperly configure agent_registry.sync_period_cron Fixes #1211 Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(tests): skip heavy docling e2e test (#1595) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat: add validation for agent import URL (#1544) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(agentstack-cli): use better heuristics for determining for adding agents (#1603) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(agentstack-cli): add server info and confirmations to CLI commands (#1590) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(cli): add SingleSelect field support to forms (#1596) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(ui): display agent-generated images in response markdown (#1601) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): render markdown in API error messages (#1593) Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com> Co-authored-by: Petr Bulánek <bulanek.petr@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * docs: add permissions and tokens page (#1576) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Matous Havlena <havlenma@gmail.com> Co-authored-by: Matous Havlena <havlenma@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(server): send proxy errors as a2a errors (#1594) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(tests): use maximize disk space action (#1607) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(tests): switch to custom model again (#1608) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: form extension rework (#1481) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(server): include redirect_uri into connector's token request (#1616) Signed-off-by: Tomas Pilar <thomas7pilar@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat: update beeai framework (#1611) Signed-off-by: Tomas Dvorak <toomas2d@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(cli): agent info command missing auth (#1622) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat(ui): redo sidebar and homepage (#1610) Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * feat: extending TS sdk (#1609) * feat: extending TS sdk Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: code review comments Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: remove GET from the callApi function, still keep the method for extensibility in the future Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: cleanup package.json Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: testing release pipeline Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: install mise Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: no git checks Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * chore: setup release action Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> * fix: code review commnets Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> --------- Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc2 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * fix(agents): add temporary fallback imports (#1624) Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc3 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: update release sdk to npm instead of pnpm Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc4 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: update npm for release Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc5 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: add release tag for npm Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc6 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: missing repository Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * release: v0.4.2-rc7 Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> * chore: run mise fix Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> --------- Signed-off-by: Eden Gilbert <eden.gilbert@ibm.com> Signed-off-by: Eden Gilbert <117227212+edengilbert@users.noreply.github.com> Signed-off-by: Petr Kadlec <petr@puradesign.cz> Signed-off-by: Tomas Pilar <thomas7pilar@gmail.com> Signed-off-by: Radek Ježek <radek.jezek@ibm.com> Signed-off-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com> Signed-off-by: Aleš Kalfas <kalfas.ales@gmail.com> Signed-off-by: Matous Havlena <havlenma@gmail.com> Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com> Signed-off-by: Tomas Dvorak <toomas2d@gmail.com> Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com> Co-authored-by: Petr Kadlec <petr@puradesign.cz> Co-authored-by: Petr Bulánek <bulanek.petr@gmail.com> Co-authored-by: Tomas Pilar <thomas7pilar@gmail.com> Co-authored-by: Radek Ježek <radek.jezek@ibm.com> Co-authored-by: Jenna Winkler <135358348+jenna-winkler@users.noreply.github.com> Co-authored-by: Tomáš Weiss <tomas.weiss2@gmail.com> Co-authored-by: Aleš Kalfas <32630459+aleskalfas@users.noreply.github.com> Co-authored-by: Matous Havlena <havlenma@gmail.com> Co-authored-by: Jan Pokorný <JenomPokorny@gmail.com> Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com> Co-authored-by: Tomas Dvorak <toomas2d@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1472